Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quickstart): fix broker InconsistentClusterIdException issues #9148

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Oct 30, 2023

Our previous Docker volume declaration was at too high a level in the file tree, which meant that the actual data was stuck in docker anonymous volumes instead of our named volume. As such, those volumes would be lost, causing zookeeper to start fresh instead of loading it's previous state. The kafka broker, which retained its state correctly, would then throw an InconsistentClusterIdException.

Repro - this sequence now works, whereas it didn't before.

datahub docker quickstart -f <file>
# ingest sample data
datahub docker quickstart --stop
datahub docker quickstart -f <file>

Closes #9047.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great fix!

@shirshanka shirshanka merged commit b565a65 into datahub-project:master Oct 31, 2023
34 checks passed
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 31, 2023
@hsheth2 hsheth2 deleted the zkdata branch November 6, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops PR or Issue related to DataHub backend & deployment hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datahub fails to restart using docker compose (dependency failed to start)
3 participants