Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python version in Developer README #9268

Merged

Conversation

kevin1chun
Copy link
Contributor

@kevin1chun kevin1chun commented Nov 17, 2023

This change adds Python 3.10 to the Local Development README page. Currently, if Python 3.11+ is used then the build process fails.

> Task :metadata-ingestion:checkPythonVersion FAILED
Traceback (most recent call last):
  File "<string>", line 1, in <module>
AssertionError: Python version (3, 11) not allowed

Py3.7 and 3.10 are technically both valid (see: https://github.com/datahub-project/datahub/blob/master/.github/workflows/metadata-ingestion.yml#L34), however, 3.7 is already EOL.

I also added the pyenv local version config file to .gitignore since this popular tool allows developers to use pyenv to control their python version.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the docs Issues and Improvements to docs label Nov 17, 2023
…Development readme. Add pyenv version file in .gitignore
@david-leifker david-leifker added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Nov 17, 2023
@david-leifker
Copy link
Collaborator

Just let the tests run to merge. Typically doc only means they don't get run but the update to the gitignore triggered them so will let them go. Thanks!

@david-leifker david-leifker merged commit d2ca2dd into datahub-project:master Nov 17, 2023
33 checks passed
@kevin1chun kevin1chun deleted the python-version-readme branch November 17, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants