Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): handle content prop changes in Editor component #9400

Merged
merged 1 commit into from
Dec 7, 2023
Merged

feat(ui): handle content prop changes in Editor component #9400

merged 1 commit into from
Dec 7, 2023

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Dec 7, 2023

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 7, 2023
chriscollins3456
chriscollins3456 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@chriscollins3456 chriscollins3456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me

@hsheth2
Copy link
Collaborator Author

hsheth2 commented Dec 7, 2023

Only failing on the │ ✖ glossary/glossary_navigation.js 01:42 1 - 1 - - │ test, so merging.

@hsheth2 hsheth2 merged commit 81a93dc into datahub-project:master Dec 7, 2023
37 of 38 checks passed
@hsheth2 hsheth2 deleted the react-editor-props branch December 7, 2023 20:59
Salman-Apptware pushed a commit to Salman-Apptware/datahub that referenced this pull request Dec 15, 2023
@hsheth2 @Salman-Apptware
feat(ui): handle content prop changes in Editor component (datahub-pr…
0a66be1 
…oject#9400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscollins3456 chriscollins3456 chriscollins3456 approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @chriscollins3456