Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ui): Minor improvements & refactoring #9420

Merged
merged 3 commits into from
Dec 14, 2023
Merged

refactor(ui): Minor improvements & refactoring #9420

merged 3 commits into from
Dec 14, 2023

Conversation

jjoyce0510
Copy link
Collaborator

Summary:

  1. Adding some graphql queries for consistency
  2. Fix loading indicators by wrapping in Spin component
  3. adding SYSTEM source type for query entity

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Dec 8, 2023
@jjoyce0510 jjoyce0510 merged commit ff0570e into datahub-project:master Dec 14, 2023
57 checks passed
Salman-Apptware pushed a commit to Salman-Apptware/datahub that referenced this pull request Dec 15, 2023
@jjoyce0510 @Salman-Apptware
refactor(ui): Minor improvements & refactoring (datahub-project#9420)
24ad4b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjoyce0510 @gabe-lyons