-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ingestion): ingest emails as empty if no ldap attribute #9433
Conversation
Emails are getting ingested as the username in cases where "mail" attribute is not set, leading to invalid emails. Fix ingestion code to leave email field empty if there is no mail attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Not sure why the previous behavior was in there to begin with, but it definitely didn't really make sense
@tkdrahn looks like the ldap integration tests are failing - could you run There's also a small lint issue |
Warning Rate limit exceeded@hsheth2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 27 minutes and 33 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
…project#9433) Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
fix(ingestion): ingest emails as empty if no ldap attribute
CorpUser emails are getting ingested as the LDAP username in cases where LDAP "email" attribute is not set, leading to invalid emails. Fix ingestion code to leave email field empty if there is no email attribute
Checklist