New-DbaAgentSchedule: Fix issues with testing for correct dates and times #9389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see why the test fails. The test uses Schedules, but I don't see a relation to the code change. Can someone help? |
|
i wondered if these were breaking changes. ill take a closer look this weekend 👍🏼 |
|
Just found a copy-paste-bug I introduced. Will fix in a minute... |
|
Now all tests pass. |
|
excellent, thanks andreas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
.\tests\manual.pester.ps1)See issue for details.
We now use the correct types for the SMO properties.
Maybe we should also add two new parameters StartDateTime and EndDateTime with [datetime] datatype as an alternative for the four string parameters. I can do this if other contributors agree.