Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test-DbaDbCompression, returns ? for empty tables (do Compression) #9474

Merged
merged 3 commits into from
Oct 5, 2024
Merged

Test-DbaDbCompression, returns ? for empty tables (do Compression) #9474

merged 3 commits into from
Oct 5, 2024

Conversation

niphlod
Copy link
Contributor

@niphlod niphlod commented Sep 25, 2024

Type of Change

  • Bug fix (non-breaking change, fixes Test-DbaDbCompression is completely silent for empty tables #9469 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Acknowledge that 0 rows table exists, and return '?' for the result instead of skipping it entirely

@potatoqualitee
Copy link
Member

Thank you, niph! 🙇🏼

@potatoqualitee potatoqualitee merged commit b58de53 into dataplat:development Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test-DbaDbCompression is completely silent for empty tables
2 participants
@niphlod @potatoqualitee