Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last page 'prev' nav inactive when using Out Of Range Extra #70

Closed
cseelus opened this issue Jul 13, 2018 · 3 comments
Closed

Last page 'prev' nav inactive when using Out Of Range Extra #70

cseelus opened this issue Jul 13, 2018 · 3 comments
Labels
bug fixed

Comments

@cseelus
Copy link
Contributor

cseelus commented Jul 13, 2018

Just a minor thing: When using Pagy::VARS[:out_of_range_mode] = :last_page the prev link is disabled on pages which are out of range and the last page is shown instead. Tested with the pagy_nav and pagy_nav_compact helper.
@ddnexus
Copy link
Owner

ddnexus commented Jul 13, 2018

Not so minor: it looks like a bug :)
Thanks

@ddnexus ddnexus added the bug label Jul 13, 2018
ddnexus added a commit that referenced this issue Jul 13, 2018
@ddnexus
fix :last_page mode in out_of_range extra (#70)
200bf23
@ddnexus ddnexus added the fixed label Jul 13, 2018
@ddnexus
Copy link
Owner

ddnexus commented Jul 13, 2018

It should work as expected now (in dev)

ddnexus added a commit that referenced this issue Jul 14, 2018
@ddnexus
fix :last_page mode in out_of_range extra (#70)
36761a8
@ddnexus ddnexus closed this as completed Jul 14, 2018
@cseelus
Copy link
Contributor Author

cseelus commented Jul 15, 2018

Quick as always, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddnexus @cseelus