Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danish translation for Pagy #232

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Danish translation for Pagy #232

merged 1 commit into from
Mar 31, 2020

Conversation

jesperronn
Copy link
Contributor

@jesperronn jesperronn commented Mar 30, 2020

Hi there!

Here is the Danish translation. I decided to follow as closely as possible the Swedish and Norwegian translations (but actually copied the EN file for this translation).

I hope you can use it 👍

Check list for a new dictionary file:

  • Find the pluralization rule for your language

    • find the locale file you need in the list of pluralizations and check the pluralization rule in it. For example for en.rb it is::RailsI18n::Pluralization::OneOther.with_locale(:en). Note the rule part i.e. OneOther. In pagy that translates to the symbol :one_other.
  • add/edit the first line comment in the language rule in your dictionary file (e.g. # :one_other pluralization ...

  • The mandatory pluralized entry in the dictionary file is the item_name. Please, provide all the plurals needed by your language. E.g. if your language uses the :east_slavic you should provide the plurals for one, few, many and other, if it uses :one_other, you should provide one and other plurals. If it uses :other you should only provide a single value. Look into other dictionary files to get some example. Ask if in doubt.

  • The other entries in the dictionary file don't need any plural variant in most languages since the pluralization of the item_name in the sentence is enough. However, in some language, the whole sentence needs to be written in a different way for different plurals. In that case you should add the different plurals for the sentence and they will get triggered by the count.

Useful Links

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #232 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #232   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          530       530           
=========================================
  Hits           530       530           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e57215f...b2bddf0. Read the comment docs.

@ddnexus ddnexus changed the base branch from master to dev March 31, 2020 04:14
@ddnexus ddnexus merged commit 246fca7 into ddnexus:dev Mar 31, 2020
@ddnexus
Copy link
Owner

ddnexus commented Mar 31, 2020

Thank you!

@ddnexus ddnexus added the merged label Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants