Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oleid: an issue in check_excel method #584

Closed
ninoseki opened this issue Jun 28, 2020 · 0 comments · Fixed by #585
Closed

oleid: an issue in check_excel method #584

ninoseki opened this issue Jun 28, 2020 · 0 comments · Fixed by #585
Assignees
Milestone

Comments

@ninoseki
Copy link
Contributor

Affected tool:
oleid

Describe the bug & How To Reproduce the bug

A direct check_excel() call causes a TypeError exception.

import oletools.oleid
from olefile import OleFileIO

with open("macro.xls", "rb") as f:
    data = f.read()
    ole_file = OleFileIO(data)

    oid = oletools.oleid.OleID(ole_file)

    oid.check_excel()

This script produces the following exception because of the wrong List append() usage. (https://github.com/decalage2/oletools/blob/master/oletools/oleid.py#L345-L346)

Traceback (most recent call last):
  File "test.py", line 10, in <module>
    oid.check_excel()
  File "/Users/foo/bar/oletools/oletools/oleid.py", line 345, in check_excel
    self.indicators.append('vba_macros', True,
TypeError: append() takes no keyword arguments

File/Malware sample to reproduce the bug

Any excel file with macro can reproduce this bug.

Version information:

  • OS: Mac
  • OS version: v10.15.5 - 64 bits
  • Python version: 3.8 - 64 bits
  • oletools version: 0.55.1 (and 0.56dev6)
ninoseki added a commit to ninoseki/oletools that referenced this issue Jun 28, 2020
@decalage2 decalage2 self-assigned this Jun 28, 2020
@decalage2 decalage2 added this to the oletools 0.56 milestone Jun 28, 2020
c-rosenberg pushed a commit to HeinleinSupport/oletools that referenced this issue Jun 22, 2021
c-rosenberg pushed a commit to HeinleinSupport/oletools that referenced this issue Dec 2, 2021
c-rosenberg pushed a commit to HeinleinSupport/oletools that referenced this issue Dec 2, 2021
ljuturu pushed a commit to ljuturu/oletools that referenced this issue Apr 21, 2022
ljuturu pushed a commit to ljuturu/oletools that referenced this issue Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants