Fix ignoring of optional whitespace after \bin. #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition was always False because self.data[self.index] returns integer. Try to put this in code before the condition: >>> print(type(self.data[self.index])) # <class 'int'> >>> print(self.data[self.index]) # 32 Thus even with space at self.index it fails: >>> 32 == ' ' # False
|
Thanks, this is actually a bug when running rtfobj with python 3. |
In my previous commit decalage2@09d42b4 I fixed this bug for Python3 but I've made a mistake when testing with Python2. Now, both Python versions should ignore whitespace after \bin correctly. Python2: >>> data = b' foo' >>> index = 0 >>> ord(data[index:index + 1]) 32 >>> ord(' ') 32 Python3 >>> data = b' foo' >>> index = 0 >>> ord(data[index:index + 1]) 32 >>> ord(' ') 32
decalage2
approved these changes
Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition is always False because
self.data[self.index]returns integer.Try to put this in code before the condition:
Thus even with space at self.index it fails:
>>> 32 == ' ' # False