Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cell file read incorrectly for 'qe/cp/traj' format #517

Closed
rashidrafeek opened this issue Aug 3, 2023 · 2 comments
Closed

[BUG] Cell file read incorrectly for 'qe/cp/traj' format #517

rashidrafeek opened this issue Aug 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working qe

Comments

@rashidrafeek
Copy link

When reading a qe/cp/traj output, the cells read from the [prefix].cel file is read incorrectly. The cells written in the [prefix].cel file produced in a cp.x calculation is transposed as mentioned here. But while reading them they are not transposed by dpdata and thereby a transposed cell instead of the original cell is read by dpdata. I noticed this when I tried to use dpdata to read a trajectory I ran previously and used the to_ase_structure function of LabeledSystem to write it into a different format and visualized it. I think the test file which tests this functionality was not created by a quantum espresso cp.x calculation.

I have modified dpdata locally to fix this and have confirmed that transposing the cell gives the desired result by visualizing. I can submit a pull request fixing this if it is okay.

@rashidrafeek rashidrafeek added the bug Something isn't working label Aug 3, 2023
amcadmus pushed a commit to amcadmus/dpdata that referenced this issue Aug 7, 2023
@wanghan-iapcm
Copy link
Contributor

@rashidrafeek Thank you very much for reporting the bug.
You are right the test file was synthetic data.
Could you please help us checking if the #520 fixes the issue and if the test file looks like one that is generated by cp.x?

@rashidrafeek
Copy link
Author

Yeah, I have tested the PR and it does fix this issue. And yes, the transposed test file in the PR is similar to the one produced by QE.

wanghan-iapcm added a commit that referenced this issue Aug 7, 2023
Co-authored-by: Han Wang <wang_han@iapcm.ac.cn>
@njzjz njzjz added the qe label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working qe
Projects
None yet
Development

No branches or pull requests

3 participants