Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: bug in reading abacus md files #496

Merged
merged 6 commits into from
Jul 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions dpdata/abacus/md.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,20 @@ def get_coord_dump_freq(inlines):
def get_coords_from_dump(dumplines, natoms):
nlines = len(dumplines)
total_natoms = sum(natoms)
# The output of VIRIAL, FORCE, and VELOCITY are controlled by INPUT parameters dump_virial, dump_force, and dump_vel, respectively.
# So the search of keywords can determine whether these datas are printed into MD_dump.
calc_stress = False
calc_force = False
check_line = 6
if "VIRIAL" in dumplines[6]:
calc_stress = True
else:
assert (
"POSITIONS" in dumplines[6] and "FORCE" in dumplines[6]
), "keywords 'POSITIONS' and 'FORCE' cannot be found in the 6th line. Please check."
check_line = 10
assert (
"POSITION" in dumplines[check_line]
), "keywords 'POSITION' cannot be found in the 6th line. Please check."
if "FORCE" in dumplines[check_line]:
calc_force = True

nframes_dump = -1
if calc_stress:
nframes_dump = int(nlines / (total_natoms + 13))
Expand Down Expand Up @@ -104,9 +111,13 @@ def get_coords_from_dump(dumplines, natoms):
if not newversion:
coords[iframe, iat] *= celldm

forces[iframe, iat] = np.array(
[float(i) for i in dumplines[iline + skipline + iat].split()[5:8]]
)
if calc_force:
forces[iframe, iat] = np.array(
[
float(i)
for i in dumplines[iline + skipline + iat].split()[5:8]
]
)
iframe += 1
assert iframe == nframes_dump, (
"iframe=%d, nframe_dump=%d. Number of frames does not match number of lines in MD_dump."
Expand Down
Loading