Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicated elements in vasp/xml #575

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented Nov 6, 2023

Fix #480.

#250 doesn't handle this situation.

@njzjz njzjz added bug Something isn't working vasp labels Nov 6, 2023
@njzjz njzjz linked an issue Nov 6, 2023 that may be closed by this pull request
@njzjz njzjz marked this pull request as draft November 6, 2023 22:25
@njzjz njzjz changed the title fix: remove duplicated unique in vasp/xml fix: fix duplicated atom names in vasp/xml Nov 6, 2023
@njzjz njzjz changed the title fix: fix duplicated atom names in vasp/xml fix duplicated atom names in vasp/xml Nov 6, 2023
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz njzjz marked this pull request as ready for review November 6, 2023 22:38
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e52b699) 82.87% compared to head (be99556) 82.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel     #575   +/-   ##
=======================================
  Coverage   82.87%   82.87%           
=======================================
  Files          74       74           
  Lines        6606     6606           
=======================================
  Hits         5475     5475           
  Misses       1131     1131           
Files Coverage Δ
dpdata/vasp/xml.py 70.78% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@njzjz njzjz changed the title fix duplicated atom names in vasp/xml fix duplicated elements in vasp/xml Nov 6, 2023
@wanghan-iapcm wanghan-iapcm merged commit e948661 into deepmodeling:devel Nov 7, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vasp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] _Problems reading vasp's output file vasprun.xml
2 participants