feat(api): Runs endpoints #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
CollectiveUnicorn
force-pushed
the
417-threads-endpoints
branch
from
f5e7dd9
to
ee2d89a
Compare
gphorvath
force-pushed
the
417-threads-endpoints
branch
from
8290b9b
to
98ea343
Compare
gphorvath
requested changes
Jun 13, 2024
src/leapfrogai_api/routers/openai/requests/create_thread_request.py
Outdated
Show resolved
Hide resolved
src/leapfrogai_api/routers/openai/requests/run_create_params_request.py
Outdated
Show resolved
Hide resolved
YrrepNoj
reviewed
Jun 13, 2024
CollectiveUnicorn
force-pushed
the
419-runs-endpoints-420-run-steps-endpoints
branch
from
760d07b
to
306cbbe
Compare
YrrepNoj
reviewed
Jun 17, 2024
…om:defenseunicorns/leapfrogai into 419-runs-endpoints-420-run-steps-endpoints
gphorvath
reviewed
Jun 17, 2024
gphorvath
reviewed
Jun 17, 2024
src/leapfrogai_api/routers/openai/requests/run_create_params_request_base.py
Show resolved
Hide resolved
YrrepNoj
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
This is a big PR that has been the work of a lot of effort. There are several conversation items that will turn into issues in our backlog. Thanks everyone for their hard work in implementing this feature.
In the future, lets set the goal of maintaining smaller PRs and introducing more testing. I'm sure I could spend another couple working days looking through this PR but I believe it would be more efficient to merge this in now (since it is in a working state where we can iterate on it independently) and start working on adding improvements in separate PRs.
Thanks again for everyones hard work in developing, reviewing, and testing this PR.
jalling97
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Streaming and non-streaming versions of runs
Naive RAG implementation that allows generating responses using results pulled from the vector store
Closes #419