chore: update release workflow trigger type #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for leapfrogai-docs canceled.
|
justinthelaw
requested changes
Sep 5, 2024
justinthelaw
approved these changes
Sep 5, 2024
CollectiveUnicorn
approved these changes
Sep 5, 2024
|
I don't see any issues with the workflow as written, the conventions all seem correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our release workflow so that the
tag-for-releaseworkflow triggers thepublishworkflow (instead of thepublishworkflow being triggered by a tag push.)Motivation: When the GitHub Bot would create a new tag in our repository the
on.push.tagtrigger would not actually trigger and a manual tag push was required. This change streamlines our release workflow to not require that middle step.The trigger logic for this change was heavily inspired (:cough: copied :cough:) from uds-core/.github/workflows/tag-and-release.yaml and uds-core/.github/workflows/publish.yaml