Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore warning in prod #1152

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: ignore warning in prod #1152

wants to merge 6 commits into from

Conversation

cmwylie19
Copy link
Collaborator

@cmwylie19 cmwylie19 commented Sep 18, 2024

Description

Ignores the warning if you are in prod, it only allows the warning in dev mode. npx pepr dev

This means you don't get the warning in the controller, or through npx pepr init|build|format

process.on('warning') won’t directly suppress the warning because it only listens to the warnings after they have been emitted.

End to End Test:
(See Pepr Excellent Examples)

Related Issue

Fixes #1147

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.87%. Comparing base (d947861) to head (74bca7f).
Report is 29 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   86.71%   85.87%   -0.84%     
==========================================
  Files          26       27       +1     
  Lines        1076     1126      +50     
  Branches      230      231       +1     
==========================================
+ Hits          933      967      +34     
- Misses        132      157      +25     
+ Partials       11        2       -9     

see 6 files with indirect coverage changes

@cmwylie19 cmwylie19 self-assigned this Sep 18, 2024
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just leaving a note that we reviewed in person -- LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

remove punycode warning when running cli options for init, build, format
2 participants