Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failover State Reporting #171

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Fix Failover State Reporting #171

merged 1 commit into from
Feb 28, 2023

Conversation

falfaroc
Copy link
Contributor

Description

During testing, it was identified that we were short-circuiting the Failover reporting status. The failoverType was still set but the failoverState was not set to Done.

To avoid incorrect Failover, we are just checking to see if the failoverType is set.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#618

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Automation testing through the pipeline.

Copy link
Collaborator

@JacobGros JacobGros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jooseppi-luna jooseppi-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@falfaroc falfaroc merged commit 099a019 into main Feb 28, 2023
@falfaroc falfaroc deleted the bugfix/failover-status branch March 17, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants