Skip to content

Commit

Permalink
add ocp416 support,update codeowner,format yaml files (#268)
Browse files Browse the repository at this point in the history
  • Loading branch information
chimanjain authored Jul 2, 2024
1 parent dfc2689 commit 759773f
Show file tree
Hide file tree
Showing 16 changed files with 42 additions and 47 deletions.
4 changes: 1 addition & 3 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@
# be requested for review when someone opens a pull request.
# order is alphabetical for easier maintenance.
#
# Adam Ginna (adamginna-dell)
# Aaron Tye (atye)
# Bogdan Novikov (bogdanNovikovDell)
# Bahubali Jain (bpjain2004)
# Bartosz Ciesielczyk (cbartoszDell)
# Chiman Jain (chimanjain)
# Christian Coffield (ChristianAtDell)
# Don Khan (donatwork)
Expand All @@ -29,4 +27,4 @@
# Shefali Malhotra (shefali-malhotra)

# for all files:
* @adamginna-dell @atye @bogdanNovikovDell @bpjain2004 @cbartoszDell @chimanjain @ChristianAtDell @donatwork @HarishH-DELL @harshaatdell @Leonard-Dell @mdutka-dell @meggm @nitesh3108 @prablr79 @rajkumar-palani @Sakshi-dell @santhoshatdell @shaynafinocchiaro @shefali-malhotra
* @atye @bogdanNovikovDell @bpjain2004 @chimanjain @ChristianAtDell @donatwork @HarishH-DELL @harshaatdell @Leonard-Dell @mdutka-dell @meggm @nitesh3108 @prablr79 @rajkumar-palani @Sakshi-dell @santhoshatdell @shaynafinocchiaro @shefali-malhotra
2 changes: 1 addition & 1 deletion dell-csi-helm-installer/verify-csi-isilon.sh
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
# verify-csi-isilon method
function verify-csi-isilon() {
verify_k8s_versions "1.21" "1.30"
verify_openshift_versions "4.14" "4.15"
verify_openshift_versions "4.15" "4.16"
verify_namespace "${NS}"
verify_required_secrets "${RELEASE}-creds"
verify_optional_secrets "${RELEASE}-certs"
Expand Down
4 changes: 2 additions & 2 deletions samples/persistentvolumeclaim/pvc-from-pvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ kind: PersistentVolumeClaim
apiVersion: v1
metadata:
name: pvc-from-pvc
namespace: default
namespace: default
spec:
accessModes:
- ReadWriteMany
- ReadWriteMany
volumeMode: Filesystem
resources:
requests:
Expand Down
2 changes: 1 addition & 1 deletion samples/persistentvolumeclaim/pvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
# pvcSoftGracePrd : "85400"
spec:
accessModes:
- ReadWriteOnce
- ReadWriteOnce
resources:
requests:
storage: 5Gi
Expand Down
18 changes: 9 additions & 9 deletions samples/pod/inline-volume.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ spec:
containers:
- name: my-frontend
image: busybox
command: [ "sleep", "100000" ]
command: ["sleep", "100000"]
volumeMounts:
- mountPath: "/data"
name: my-csi-volume
- mountPath: "/data"
name: my-csi-volume
volumes:
- name: my-csi-volume
csi:
driver: csi-isilon.dellemc.com
volumeAttributes:
size: "2Gi"
ClusterName: "cluster1"
- name: my-csi-volume
csi:
driver: csi-isilon.dellemc.com
volumeAttributes:
size: "2Gi"
ClusterName: "cluster1"
22 changes: 11 additions & 11 deletions samples/pod/nginx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,15 @@ metadata:
name: nginx-pv-pod
spec:
containers:
- name: task-pv-container
image: nginx
ports:
- containerPort: 80
name: "http-server"
volumeMounts:
- mountPath: "/usr/share/nginx/html"
name: task-pv-storage
- name: task-pv-container
image: nginx
ports:
- containerPort: 80
name: "http-server"
volumeMounts:
- mountPath: "/usr/share/nginx/html"
name: task-pv-storage
volumes:
- name: task-pv-storage
persistentVolumeClaim:
claimName: test-pvc
- name: task-pv-storage
persistentVolumeClaim:
claimName: test-pvc
3 changes: 1 addition & 2 deletions samples/secret/secret.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
isilonClusters:
# logical name of PowerScale Cluster
# logical name of PowerScale Cluster
- clusterName: "cluster1"

# username for connecting to PowerScale OneFS API server
Expand Down Expand Up @@ -75,4 +75,3 @@ isilonClusters:
# password: "password"
# endpoint: "1.2.3.4"
# endpointPort: "8080"

1 change: 0 additions & 1 deletion samples/storageclass/isilon-replication.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ parameters:
# until a Pod using the PersistentVolumeClaim is created
# Default value: Immediate
volumeBindingMode: Immediate

# allowedTopologies helps scheduling pods on worker nodes which match all of below expressions.
# If enableCustomTopology is set to true in helm values.yaml, then do not specify allowedTopologies
# Change all instances of <ISILON_IP> to the IP of the PowerScale OneFS API server
Expand Down
1 change: 0 additions & 1 deletion samples/storageclass/isilon.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ parameters:
# until a Pod using the PersistentVolumeClaim is created
# Default value: Immediate
volumeBindingMode: Immediate

# allowedTopologies helps scheduling pods on worker nodes which match all of below expressions.
# If enableCustomTopology is set to true in helm values.yaml, then do not specify allowedTopologies
# Change all instances of <ISILON_IP> to the IP of the PowerScale OneFS API server
Expand Down
4 changes: 2 additions & 2 deletions test/helm/10vols/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ appVersion: 1.0.0
description: |
Tests isilon CSI deployments.
keywords:
- csi-isilon
- storage
- csi-isilon
- storage
engine: gotpl
4 changes: 2 additions & 2 deletions test/helm/1vol/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ appVersion: 1.0.0
description: |
Test CSI Isilon deployment.
keywords:
- csi-isilon
- storage
- csi-isilon
- storage
engine: gotpl
4 changes: 2 additions & 2 deletions test/helm/2vols+restore/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ appVersion: 1.0.0
description: |
Tests Isilon CSI deployments.
keywords:
- isilon-csi
- storage
- isilon-csi
- storage
engine: gotpl
4 changes: 2 additions & 2 deletions test/helm/2vols/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ appVersion: 1.0.0
description: |
Tests isilon CSI deployments.
keywords:
- csi-isilon
- storage
- csi-isilon
- storage
engine: gotpl
4 changes: 2 additions & 2 deletions test/helm/7vols/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ appVersion: 1.0.0
description: |
Tests CSI deployments.
keywords:
- csi-isilon
- storage
- csi-isilon
- storage
engine: gotpl
6 changes: 3 additions & 3 deletions test/ingestion/sample/isilonstaticpv.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ spec:
csi:
driver: csi-isilon.dellemc.com
volumeAttributes:
Path: "/ifs/data/csi/isilonvol"
Name: "isilonvol"
AzServiceIP: 'XX.XX.XX.XX'
Path: "/ifs/data/csi/isilonvol"
Name: "isilonvol"
AzServiceIP: "XX.XX.XX.XX"
volumeHandle: isilonvol=_=_=652=_=_=System=_=_=cluster
claimRef:
name: isilonstaticpvc
Expand Down
6 changes: 3 additions & 3 deletions test/ingestion/sample/isilonstaticpvc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ metadata:
namespace: default
spec:
accessModes:
- ReadWriteMany
- ReadWriteMany
resources:
requests:
storage: 5Gi
requests:
storage: 5Gi
volumeName: isilonstaticpv
storageClassName: isilon

0 comments on commit 759773f

Please sign in to comment.