Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replicated PV having incorrect AzServiceIP value #142

Merged
merged 6 commits into from
Nov 1, 2022

Conversation

santhoshatdell
Copy link
Contributor

@santhoshatdell santhoshatdell commented Oct 28, 2022

Description

Storage class design for the PowerScale does not provide sufficient information to the driver on the source k8s cluster when creating a remote volume. With current implementation, only the target SC on the remote k8s cluster has the required information.
I don’t think we should be retrieving the target SC from remote k8s cluster in the source side driver. So I added few replication parameters as you can see in samples/storageclass/isilon-replication.yaml. With this fix, the replicated PV is set with its own properties (AzServiceIp, access zone and rootClientEnabled).

Changes will be made in repctl tool to support this and csm-docs will be updated.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#514

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed driver on both source and target k8s clusters.
  • Created Storage Class on both k8s clusters.
  • When provisioned with updated storage class, PVs on both sides are set with their own properties (AccessZone, AzServiceIp and RootClientEnabled). Please note that I do not have a lab set up that has AzServiceIP configured. I will reach out to Florian on this.
  • Verified on PowerScale REST API and logs that the parameters are used as expected - volume ID and details of remote export.

@santhoshatdell santhoshatdell merged commit 4aea61e into main Nov 1, 2022
@santhoshatdell santhoshatdell deleted the bugfix-514-target-PV-wrong-AzServiceIP branch November 1, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants