Sanity Test Fixes #296
Merged
Sanity Test Fixes #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhatdell
requested review from
adarsh-dell,
AkshaySainiDell,
boyamurthy,
bpjain2004,
ChristianAtDell,
delldubey,
francis-nijay,
gilltaran,
harishp8889,
harshitap26,
kenivi1,
niranjan-n1,
prablr79,
satyakonduri,
santhoshhs10,
shanmydell,
suryagupta4 and
tssushma
as code owners
shanmydell
requested changes
Jan 11, 2024
shanmydell
reviewed
Jan 11, 2024
tests/sanity/Dockerfile
Outdated
| @@ -14,12 +14,15 @@ | |||
| # | |||
| # | |||
|
|
|||
| FROM golang:1.13.4 as build-env | |||
| FROM golang:1.20.2 as build-env | |||
There was a problem hiding this comment.
Can we update it to 1.21 or 1.22?
shanmydell
previously approved these changes
Jan 11, 2024
|
@rishabhatdell The copyright years in all modified files are not correctly updated; please replace 2023 with 2024. |
updated @adarsh-dell |
shanmydell
approved these changes
Jan 11, 2024
AkshaySainiDell
approved these changes
Jan 12, 2024
Thanks @rishabhatdell Approved. |
adarsh-dell
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the outdated sanity tests
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration