Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update if-check for the failover REST failure #307

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

delldubey
Copy link
Contributor

Description

Update if-check for the failover REST failure

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1109

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit Test
  • Cluster Test

shanmydell
shanmydell previously approved these changes Feb 5, 2024
@shanmydell
Copy link
Contributor

@delldubey : Please fix the unit tests

Copy link

@nidtara nidtara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shanmydell
Copy link
Contributor

@delldubey : Please sign the commits

Signed-off-by: Utkarsh Dubey <Utkarsh.Dubey@Dell.com>
@delldubey delldubey merged commit b66cdd0 into main Feb 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants