Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Common Go Image #312

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Use Common Go Image #312

merged 3 commits into from
Feb 21, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented Feb 19, 2024

Description

Use Common go Image for building driver and update github actions.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1098

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Built Driver Image
  localhost/dellemc/csi-powerstore                      v2.9.0           8281de8de314  58 minutes ago     250 MB
  • Ran Sanity Test
[1/2] STEP 5/5: RUN GOOS=linux CGO_ENABLED=0 go build -o csi-powerstore ./cmd/csi-powerstore
--> cdaff58f1603
[2/2] STEP 1/9: FROM localhost/csipowerstore-ubimicro:latest
[2/2] STEP 2/9: WORKDIR /
--> fa67e16e74e9
[2/2] STEP 3/9: LABEL vendor="Dell Inc."       name="csi-powerstore"       summary="CSI Driver for Dell EMC PowerStore"       description="CSI Driver for provisioning persistent storage from Dell EMC PowerStore"       version="2.9.0"       license="Apache-2.0"
--> c3277bf48fae
[2/2] STEP 4/9: COPY licenses /licenses
--> ad376cdff938
[2/2] STEP 5/9: RUN which mkfs.ext4
/usr/sbin/mkfs.ext4
--> fd6176b0e022
[2/2] STEP 6/9: RUN which mkfs.xfs
/usr/sbin/mkfs.xfs
--> 232d803f0bdd
[2/2] STEP 7/9: RUN echo "export PATH=$PATH:/sbin:/bin" > /etc/profile.d/ubuntu_path.sh
--> 910c50c6c5cb
[2/2] STEP 8/9: COPY --from=builder /workspace/csi-powerstore /
--> ee80bbe6cde1
[2/2] STEP 9/9: ENTRYPOINT ["/csi-powerstore"]
[2/2] COMMIT dellemc/csi-powerstore:v2.9.0
--> e4372959865b
Successfully tagged localhost/dellemc/csi-powerstore:v2.9.0

adarsh-dell
adarsh-dell previously approved these changes Feb 19, 2024
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @chimanjain , could you please consider adding a screenshot of the output from the make docker command?

@chimanjain
Copy link
Contributor Author

Looks good to me. @chimanjain , could you please consider adding a screenshot of the output from the make docker command?

Done

cbartoszDell
cbartoszDell previously approved these changes Feb 20, 2024
nitesh3108
nitesh3108 previously approved these changes Feb 20, 2024
Copy link

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chimanjain chimanjain merged commit 3d7d347 into main Feb 21, 2024
8 of 10 checks passed
@chimanjain chimanjain deleted the use-base-go-image branch June 21, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants