Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update OCP/K8s min/max support version to be consistent with documentation #321

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

abhi16394
Copy link
Contributor

@abhi16394 abhi16394 commented Mar 27, 2024

Description

OCP min/max version and k8s max version support does not match documentation: https://dell.github.io/csm-docs/docs/prerequisites/
Updating the verify script to include supported version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1203

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Copy link

@hoppea2 hoppea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhi16394 let's track this via a GitHub defect as well

@abhi16394
Copy link
Contributor Author

@abhi16394 let's track this via a GitHub defect as well

Added an issue to PR

@abhi16394 abhi16394 merged commit 290f088 into main Mar 27, 2024
5 checks passed
@abhi16394 abhi16394 deleted the updateVersion branch March 27, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants