Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume limits support for CSI Powerstore #723

Closed
wants to merge 4 commits into from

Conversation

alankar-verma
Copy link
Contributor

@alankar-verma alankar-verma commented Jul 25, 2023

Description

Support for volume limits feature in CSI Powerstore driver. The feature can be used either by setting :

  • maxPowerstoreVolumesPerNode in values.yaml
  • setting node label "max-powerstore-volumes-per-node"

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#876

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Test Results

55 tests  ±0   55 ✔️ ±0   1s ⏱️ ±0s
  3 suites ±0     0 💤 ±0 
  1 files   ±0     0 ±0 

Results for commit ad937d6. ± Comparison against base commit fa4b6fa.

♻️ This comment has been updated with latest results.

Copy link

@rsedlock1958 rsedlock1958 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make changes as noted

@alankar-verma
Copy link
Contributor Author

Make changes as noted

Made the required changes

The user can set the volume limit for a node by creating a node label `max-powerstore-volumes-per-node` and specifying the volume limit for that node.
<br/> `kubectl label node <node_name> max-powerstore-volumes-per-node=<volume_limit>`

The user can also set the volume limit for all the nodes in the cluster by specifying the same to `maxPowerstoreVolumesPerNode` attribute in values.yaml.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alankar-verma Also mention here how to set the volume limit in case of driver installed via operator.

@suryagupta4
Copy link
Contributor

@alankar-verma
Add the env in the sample CR as well in case of operator.
file: content/docs/csidriver/installation/operator/powerstore.md

@alankar-verma
Copy link
Contributor Author

Closing this PR as target branch should be release-1.8.0 instead of main. Created a new PR #782

@gallacher gallacher deleted the powerstore-volume-limits branch November 1, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants