Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating latest go dependencies #136

Merged
merged 1 commit into from
May 28, 2024
Merged

Updating latest go dependencies #136

merged 1 commit into from
May 28, 2024

Conversation

boyamurthy
Copy link
Contributor

Updating latest go dependencies

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1280

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

delldubey
delldubey approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@delldubey delldubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nidtara
nidtara approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@nidtara nidtara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boyamurthy boyamurthy merged commit 6c59081 into main May 28, 2024
8 checks passed
@santhoshatdell santhoshatdell deleted the update_go_dependencies branch August 19, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delldubey delldubey delldubey approved these changes

@nidtara nidtara nidtara approved these changes

@AronAtDell AronAtDell Awaiting requested review from AronAtDell

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth

@ChristianAtDell ChristianAtDell Awaiting requested review from ChristianAtDell

@donatwork donatwork Awaiting requested review from donatwork

@gallacher gallacher Awaiting requested review from gallacher

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@hoppea2 hoppea2 Awaiting requested review from hoppea2

@santhoshatdell santhoshatdell Awaiting requested review from santhoshatdell santhoshatdell is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boyamurthy @delldubey @nidtara