Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve Cluster UID #78

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Retrieve Cluster UID #78

merged 3 commits into from
Feb 15, 2023

Conversation

falfaroc
Copy link
Contributor

@falfaroc falfaroc commented Feb 15, 2023

Description

Retrieves the cluster UID of the system that is unique between clusters at the creation of the sidecar. The intention is to provide this information to the drivers if they wish to use it in any form when creating the name of the RCG for better identification.

It is ensured that the cluster UID is only retrieved once to avoid constantly querying during reconciles.

Example:
image
In PowerFlex, cluster UID is added to the name. It is truncated to fit the limitations of the max name length.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#618

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested on multiple clusters to ensure that the cluster UID is being retrieved correctly and passed as a parameter to the driver.

santhoshatdell
santhoshatdell previously approved these changes Feb 15, 2023
cmd/csi-replicator/main.go Outdated Show resolved Hide resolved
@falfaroc falfaroc merged commit bccb771 into main Feb 15, 2023
@santhoshatdell santhoshatdell deleted the get-cluster-uuid branch February 16, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants