Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty string for protectionPolicyId for it to be unassigned from VolumeGroup #111

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

santhoshatdell
Copy link
Contributor

@santhoshatdell santhoshatdell commented Aug 9, 2023

PR Submission checklist

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#928

Common PR Checklist:

  • Have you made sure that the code compiles?
  • Have you commented your code, particularly in hard-to-understand areas
  • Did you run tests in a real Kubernetes cluster?
  • Have you maintained backward compatibility

Description of your changes:

  • Reverting the changes w.r.t VolumeGroupModify struct that was made during terraform VolumeGroup updates.
  • When modify VG call was sent earlier with empty string for protectionPolicyId, it used to unassign the policy from VG so that the VG can be deleted (for replication).
  • Tested the array API and noticed no issues there.

Unit tests:
PASS
github.com/dell/gopowerstore coverage: 84.2% of statements
ok github.com/dell/gopowerstore 0.054s coverage: 84.2% of statements
...
PASS
github.com/dell/gopowerstore/api coverage: 81.9% of statements
ok github.com/dell/gopowerstore/api 4.030s coverage: 81.9% of statements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants