Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for replication on a PowerFlex 4.0 array #44

Merged
merged 2 commits into from
Feb 10, 2023

Conversation

falfaroc
Copy link
Collaborator

@falfaroc falfaroc commented Feb 7, 2023

Description

Add support for all replication API calls in a PowerFlex 4.0 array. The main chances are:

  • Changing the force flag in CreateReplicationConsistencyGroupSnapshot to a boolean.
  • Changing the PauseMode to StopDataTransfer since that is only supported in a 4.0 system.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#618

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Tested to ensure that all of the replication integration tests work on both a PowerFlex 3.6 and PowerFlex 4.0 array.

@falfaroc falfaroc self-assigned this Feb 7, 2023
Copy link
Collaborator

@kumarkgosa kumarkgosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@falfaroc falfaroc merged commit 57ee14d into main Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants