Add Support for OCP 4.16 and k8s 1.30 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chimanjain
requested review from
gallacher,
tdawe,
alikdell,
atye,
hoppea2,
coulof,
shaynafinocchiaro,
sharmilarama,
EvgenyUglov,
bjiang27,
Sahiba-Gupta,
aqu-dell,
jackieung-dell,
taohe1012,
P-Cao,
baoy1,
YianZong,
forrestxia,
donatwork,
harshaatdell,
anandrajak1,
shefali-malhotra,
panigs7,
nitesh3108,
rajendraindukuri and
HarishH-DELL
as code owners
shefali-malhotra
approved these changes
Jul 2, 2024
donatwork
reviewed
Jul 2, 2024
| @@ -30,7 +30,8 @@ A Linux based system, with internet access, will be used to execute the script t | |||
| | `jq` | `jq` will be used to parse the Karavi Authorization configuration file during installation| | |||
|
|
|||
| ## Installation script | |||
| The installation script is located at https://github.com/dell/karavi-observability/blob/main/installer/karavi-observability-install.sh. The script performs the current steps during installation of Karavi Observability: | |||
|
|
|||
| The installation script is located at <https://github.com/dell/karavi-observability/blob/main/installer/karavi-observability-install.sh>. The script performs the current steps during installation of Karavi Observability: | |||
There was a problem hiding this comment.
Do we still need to refer to the product as Karavi Observability? Can it be CSM Observability?
There was a problem hiding this comment.
The repository is named karavi-observability, if we can rename it, maybe we can remove its reference.
donatwork
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Support for OCP 4.16 and k8s 1.30
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist: