Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for AzureSQL to AzureSQL #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sumeetdas-dlpx
Copy link

@sumeetdas-dlpx sumeetdas-dlpx commented Oct 14, 2024

Problem

In order to support AzureSQL to AzureSQL masking, we need to add type mappings from Azure SQL data types to ADF data types.

Solution

  1. Wrote a migration script that will add type mappings from Azure SQL data types to ADF data types in adf_type_mappings table.
  2. Excluded the following types since we cannot mask them - table, cursor, sql_variant, hierarchyid, rowversion

Testing Done

Verified the mappings via Projection:

Screenshot 2024-10-14 at 5 31 30 PM Screenshot 2024-10-14 at 5 31 50 PM

@sumeetdas-dlpx sumeetdas-dlpx force-pushed the dlpx/pr/sumeetdas-dlpx/54f61d75-9764-41ae-9ac3-af90c71ef254 branch from 8402370 to d236cab Compare October 14, 2024 05:41
@sumeetdas-dlpx
Copy link
Author

I'm aware PrePush Jira checks are failing because I did not add the JIRA ticket number in the PR title. I'm not sure if we should add it given that previous PRs and commits on this repo did not have the JIRA ID.

@sumeetdas-dlpx sumeetdas-dlpx marked this pull request as ready for review October 14, 2024 12:06
@sumeetdas-dlpx sumeetdas-dlpx requested a review from a team as a code owner October 14, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant