perf(lsp): release unused documents #23398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwhit
reviewed
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TS language service will call
documentRegistry.releaseDocumentWithKey()for sources that aren't found in the graph. We couldn't benefit from that until #23259 because we used to pass all known documents as roots.Also, don't use
sourceFileCachefor LSP documents. There is a differentts.SourceFileAPI which is used by the document registry. Trying to reusehost.getSourceFile()/sourceFileCachewas causing sources to be parsed twice I think. Use a separatesourceTextCache.Like the VSCode TS server does, use a ref counter to count acquisitions of source files and only release when it decrements to 0. Currently this can only move between 1 and 0. But later when we have a
ts.LanguageServiceobject per-deno.json-scope, it will count how many scopes are currently interested in each source file.Replace
TsServer::restart()with a more targetedTsServer::cleanup_semantic_cache(). We don't want to lose these ref counts in the middle of the program.