fix(coverage): ignore urls from doc testing #25736
Merged
+53
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt3k
commented
Sep 19, 2024
cli/tools/coverage/mod.rs
Outdated
| @@ -452,6 +452,10 @@ fn filter_coverages( | |||
| let exclude: Vec<Regex> = | |||
| exclude.iter().map(|e| Regex::new(e).unwrap()).collect(); | |||
|
|
|||
| // Matches virtual file paths for doc testing | |||
| // e.g. file:///path/to/mod.ts$23-29.ts | |||
| let doc_test_re = Regex::new(r"\$\d+-\d+\.(ts|js)$").unwrap(); | |||
There was a problem hiding this comment.
@magurotuna Do you know what are the possible file extensions from doc example extraction?
There was a problem hiding this comment.
The extension is taken from the code fence, like:
```ts
// becomes .ts
```
```tsx
// becomes .tsx
```Possible extensions are listed here
https://deno-docs--magurotuna-improved-doc-te.deno.dev/runtime/fundamentals/testing/#documentation-tests
- js
- javascript
- mjs
- cjs
- jsx
- ts
- typescript
- mts
- cts
- tsx
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started executing doc examples in #25220. Because of that change, now the coverage data for generated urls like
file:///path/to/module.ts$20-30.tsare generated, anddeno coveragefails by trying to fetch that file from the cache. This behavior causes #25732This PR fixes the above by ignoring urls of the pattern
\$\d+-\d+\.(ts|js)$when collecting the coverage data.closes #25732