Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): support partitioned cookies #5044

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

KlaasSkelteAtEnatom
Copy link
Contributor

@KlaasSkelteAtEnatom KlaasSkelteAtEnatom commented Jun 14, 2024

closes #5043

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the http label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.17%. Comparing base (22b4d03) to head (802c56a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5044   +/-   ##
=======================================
  Coverage   92.17%   92.17%           
=======================================
  Files         487      487           
  Lines       38796    38800    +4     
  Branches     5433     5435    +2     
=======================================
+ Hits        35760    35764    +4     
  Misses       2981     2981           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k
Copy link
Member

kt3k commented Jun 14, 2024

Note:

Browser support:

Library support:

I think it's probably fine to add this now.

Does anyone have any opinion on this?

http/cookie.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this change. LGTM.

@kt3k kt3k changed the title feat(http): Support partitioned cookies feat(http): support partitioned cookies Jun 14, 2024
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iuioiua iuioiua merged commit d35f8a3 into denoland:main Jun 15, 2024
13 checks passed
@KlaasSkelteAtEnatom KlaasSkelteAtEnatom deleted the partitioned-cookies branch June 17, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Cookies Having Independent Partitioned State (CHIPS)/Partioned cookies in http/cookie.ts
4 participants