Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all the legacy handlers #569

Closed
wants to merge 2 commits into from
Closed

Conversation

dadamu
Copy link
Contributor

@dadamu dadamu commented Jul 21, 2021

Description

This PR is implementation of #566.
Closes #566.

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Wrote integration tests (simulation & CLI).
  • Updated the documentation.
  • Added an entry to the CHANGELOG.md file.
  • Re-reviewed Files changed in the Github PR explorer.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #569 (98d0883) into master (71960c8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #569   +/-   ##
=======================================
  Coverage   15.70%   15.70%           
=======================================
  Files         168      168           
  Lines       45954    45954           
=======================================
  Hits         7218     7218           
  Misses      38119    38119           
  Partials      617      617           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71960c8...98d0883. Read the comment docs.

@dadamu
Copy link
Contributor Author

dadamu commented Jul 23, 2021

Sim tests will be solved once cosmos/cosmos-sdk#9139 is out.
Currently, message still pass via legacy route since the current message doesn't implement ServiceMsg struct to get the MethodName for msgServiceRouter.Handler(), In addition, the struct will be deprecated in the next version.

@dadamu dadamu marked this pull request as ready for review July 23, 2021 10:17
@dadamu dadamu added the status/waiting-upstream This issue is waiting for a dependency to be updated in order to be worked on label Jul 23, 2021
@github-actions github-actions bot added kind/adr An issue or PR relating to an architectural decision record kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI x/profiles Module that allows to create and manage decentralized social profiles labels Sep 14, 2021
@dadamu dadamu removed the status/waiting-upstream This issue is waiting for a dependency to be updated in order to be worked on label Sep 28, 2021
@dadamu dadamu force-pushed the paul/remove-legacy-handlers branch from 65d63ee to 98d0883 Compare October 21, 2021 05:11
@github-actions github-actions bot removed kind/build Related to the build of the project kind/ci Improve the CI/CD x/CLI labels Oct 21, 2021
@RiccardoM
Copy link
Contributor

Closing as it's referring to old code that is no longer there

@RiccardoM RiccardoM closed this Feb 4, 2022
@RiccardoM RiccardoM deleted the paul/remove-legacy-handlers branch March 21, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/adr An issue or PR relating to an architectural decision record x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all the legacy handlers
2 participants