Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Boundary Nodes persist #222

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Add Boundary Nodes persist #222

merged 7 commits into from
Jun 5, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Feb 29, 2024 •
edited
Loading

  • Add persistence for boundary nodes
  • Test persist function

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner February 29, 2024 17:05
NikolaMilosa
NikolaMilosa approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Mar 1, 2024
sasa-tomic
sasa-tomic approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...bility/multiservice-discovery/src/server_handlers/add_boundary_node_to_definition_handler.rs Show resolved Hide resolved
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 1, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity merged commit 657ac3f into main Jun 5, 2024
5 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the add-boundary-nodes-definition branch June 5, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa-tomic sasa-tomic sasa-tomic approved these changes

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pietrodimarco-dfinity @sasa-tomic @NikolaMilosa