New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Heal command #468

Merged

pietrodimarco-dfinity merged 46 commits into main from heal-all-subnets

Jun 18, 2024

Contributor

pietrodimarco-dfinity commented Jun 7, 2024 •

edited by sasa-tomic

Loading

This introduces the heal command, designed to improve the health of the network by replacing unhealthy nodes within specified subnets.
The command traverses all nodes in the network, identifying and replacing the unhealthy in each subnet.

Users can optionally specify the argument --max-replaceable-nodes-per-sub to optimize the healing process up to max-replaceable-nodes-per-sub nodes.
If the --max-replaceable-nodes-per-sub argument is not provided, the algorithm will proceed replacing all and only the unhealthy nodes in the subnets.

pietrodimarco-dfinity and others added 4 commits

June 1, 2024 09:45


          Heal all subnets

cacf9d7


          Merge branch 'main' into heal-all-subnets

6e49b04


          Fix bazel

10d4e2a


          Add heal comand and endpoint

a018d38

pietrodimarco-dfinity requested a review from a team as a code owner

June 7, 2024 15:42

pietrodimarco-dfinity marked this pull request as draft

June 7, 2024 15:42

pietrodimarco-dfinity changed the title ~~Heal all subnets~~ Add Heal Network command

pietrodimarco-dfinity and others added 14 commits

June 7, 2024 17:43


          Merge branch 'main' into heal-all-subnets

7ccc138


          Fix Clippy

0a36de1


          Fix fmt

a2411ac


          Compute local optimum based on max-replacable-nodes

4964b09


          Test multi concurrent proposals

c3457c3


          Merge branch 'main' into heal-all-subnets

f68dd23


          Run rustftm

d1066b9


          Add subnet name

4b02f29


          Merge branch 'main' into heal-all-subnets

bf8d0af


          Move unhealthy in separate function

05e94ea


          Remove optimize_with_limit

a172508


          Merge branch 'main' into heal-all-subnets

dd8a787


          Run rustfmt

6b79b8a


          Fixed clippy

8c8f6d0

pietrodimarco-dfinity changed the title ~~Add Heal Network command~~ Add Heal command

pietrodimarco-dfinity added 3 commits

June 11, 2024 11:54


          Fixing clippy

173e4b8


          Refactor heal method

923e24b


          Fix rustfmt

b29684e

pietrodimarco-dfinity marked this pull request as ready for review

June 11, 2024 16:22


          Add NetworkHealRequest

21a517b

pietrodimarco-dfinity marked this pull request as draft

June 12, 2024 07:35

pietrodimarco-dfinity added 2 commits

June 12, 2024 18:05


          Add removed anyhow

0ee7cd5


          Add ordering of subnets

d56031b

pietrodimarco-dfinity and others added 7 commits

June 17, 2024 13:24


          Add tests

5cb3e45


          Run rustfmt

9ccf3ef


          Merge branch 'main' into heal-all-subnets

19de17e


          Add test

cae5322


          Merge branch 'main' into heal-all-subnets

ab9a676


          Fix clippy

7676b5b


          Fix clippy

28b4d57

pietrodimarco-dfinity marked this pull request as ready for review

June 17, 2024 16:10


          Removed unecessary derive

64b039f

sasa-tomic reviewed

View reviewed changes

Member

sasa-tomic left a comment

Looks great! Thank you!

rs/cli/src/main.rs Outdated Show resolved Hide resolved

rs/cli/src/main.rs Outdated Show resolved Hide resolved

rs/cli/src/runner.rs Outdated Show resolved Hide resolved

rs/decentralization/src/network.rs Outdated Show resolved Hide resolved

rs/cli/src/cli.rs Outdated Show resolved Hide resolved

rs/decentralization/src/network.rs Outdated Show resolved Hide resolved

rs/ic-management-types/src/requests.rs Outdated Show resolved Hide resolved

rs/ic-management-backend/src/endpoints/network.rs Outdated Show resolved Hide resolved

rs/decentralization/src/network.rs Outdated Show resolved Hide resolved

rs/decentralization/src/network.rs Outdated Show resolved Hide resolved

pietrodimarco-dfinity and others added 11 commits

June 17, 2024 19:35


          Update rs/cli/src/main.rs

3535c43

Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Update rs/cli/src/main.rs

c145360

Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Update rs/decentralization/src/network.rs

Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Update rs/cli/src/cli.rs

188e4f7

Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Update rs/decentralization/src/network.rs

Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Update rs/ic-management-types/src/requests.rs

b779c5c

Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Update rs/ic-management-backend/src/endpoints/network.rs

96f5ad8

Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Update rs/decentralization/src/network.rs

39eab14

Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Update rs/decentralization/src/network.rs

5a9a5d4

Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Add take max replacement unhealthy

1aa10db


          Merge branch 'main' into heal-all-subnets

2ac4ea5

pietrodimarco-dfinity requested a review from sasa-tomic

June 17, 2024 19:15

sasa-tomic reviewed

View reviewed changes

rs/decentralization/src/network.rs Outdated Show resolved Hide resolved

sasa-tomic approved these changes

View reviewed changes

Member

sasa-tomic left a comment

Awesome!

NikolaMilosa approved these changes

View reviewed changes

Contributor

NikolaMilosa left a comment

Noice job machine 🤖

rs/cli/src/runner.rs Show resolved Hide resolved

rs/cli/src/runner.rs Outdated Show resolved Hide resolved

rs/decentralization/src/network.rs Show resolved Hide resolved

rs/ic-management-backend/src/subnets.rs Outdated Show resolved Hide resolved

pietrodimarco-dfinity and others added 3 commits

June 18, 2024 13:15


          Merge branch 'main' into heal-all-subnets

9b3947d


          Apply suggestions from code review

ce209c9

Co-authored-by: Nikola Milosavljevic <73236646+NikolaMilosa@users.noreply.github.com>
Co-authored-by: Saša Tomić <sasa.tomic@dfinity.org>


          Run rustfmt

96ce52e

pietrodimarco-dfinity merged commit 099fc6d into main

4 checks passed

pietrodimarco-dfinity deleted the heal-all-subnets branch

June 18, 2024 11:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet