Bump vitest and webdriverio #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading these dependencies fixes dependabot alerts. Requires pinning a specific version of `ws` though. This should be removed in the future. Includes changes to the vitest arguments to run tests sequentially, because the options changed in the upgrade to `1.x.x`.
lmuntaner
approved these changes
Jun 25, 2024
| @@ -75,6 +75,9 @@ | |||
| "ua-parser-js": "^1.0.35", | |||
| "zod": "^3.22.3" | |||
| }, | |||
| "overrides": { | |||
| "ws": "8.17.1" | |||
There was a problem hiding this comment.
This was necessary in the end?
Which are the packages we need to watch to upgrade to be able to remove this?
Could you add it in the PR description so that we can come back to it to better understand it?
There was a problem hiding this comment.
Yes, it was. puppeteer-core seems to be the culprit:
+-- vitest@1.6.0
| `-- jsdom@20.0.3
| `-- ws@8.17.1 overridden
`-- webdriverio@8.39.0
+-- devtools@8.39.0
| `-- puppeteer-core@20.3.0
| `-- ws@8.13.0 invalid: "8.17.1" from node_modules/devtools/node_modules/puppeteer-core overridden
+-- puppeteer-core@20.9.0
| `-- ws@8.13.0 invalid: "8.17.1" from node_modules/puppeteer-core overridden
`-- webdriver@8.39.0
`-- ws@8.17.1 deduped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading these dependencies fixes dependabot alerts. Requires pinning a specific version of
wsthough. This should be removed in the future.Includes changes to the vitest arguments to run tests sequentially, because the options changed in the upgrade to
1.x.x.Once we update
webdriveriowe should hopefully transitively get a newer version ofwsso that the override is no longer necessary.🟡 Some screens were changed