feat: allow controllers to call __motoko_stable_var_info query endpoint
#4103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
force-pushed
the
gabor/controller-footprint
branch
from
7f07d08
to
edb8e6c
Compare
crusso
reviewed
Jul 6, 2023
| @@ -438,8 +438,9 @@ and export_footprint self_id expr = | |||
| ([ letD (var v typ) ( | |||
| funcE v (Shared Query) Promises [bind1] [] [ret_typ] ( | |||
| (asyncE T.Fut bind2 | |||
| (blockE [expD (assertE (primE (I.RelPrim (caller, Operator.EqOp)) | |||
| [primE I.ICCallerPrim []; selfRefE caller])); | |||
| (blockE [expD (assertE (orE (primE (I.RelPrim (caller, Operator.EqOp)) | |||
There was a problem hiding this comment.
Might be cheaper to call ICCallerPrim just once, but don't think it matters.
There was a problem hiding this comment.
I am not overly concerned :-)
crusso
approved these changes
Jul 6, 2023
|
I guess we could now provide a helper in ExperimentalInternetComputer to call this on another canister than self, but not urgent. |
ggreif
added a commit
that referenced
this pull request
Jul 6, 2023
reacting to the comment #4103 (comment)
mergify bot
pushed a commit
that referenced
this pull request
Jul 6, 2023
reacting to the #4103 (comment) Turns out that the backend generates quite some code to build the caller principal, so we do it only once now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally spec-ed, but there was no possibility to implement it (a canister couldn't get its own controller list).
In the meantime canisters can get their controller list (via query), but a query cannot call another query 🫤.
So we had to wait until the
ic0.is_controllersyscall became available. Now it is there and the implementation is easy.(It was technically possible to call it before, but it invariably trapped.)