Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to global maps #4106

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Remove reference to global maps #4106

merged 8 commits into from
Jul 6, 2023

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity added the build_artifacts Upload moc binary as workflow artifacts label Jul 6, 2023
@chenyan-dfinity
Copy link
Contributor Author

I can confirm this indeed fixes the problem.

@chenyan-dfinity chenyan-dfinity marked this pull request as ready for review July 6, 2023 02:33
@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited
Loading

Comparing from ee58d35 to 64c5fa0:
The produced WebAssembly code seems to be completely unchanged.

@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited
Loading

Download the artifacts for this pull request:

crusso
crusso approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A cleaner fix might be to move the globals and auxiliary helper functions into gather, making them local.

I'll try that in a follow on PR, if you don't want to.

UPDATE see #4107

@crusso crusso mentioned this pull request Jul 6, 2023
Merged
crusso and others added 2 commits July 6, 2023 10:00
@crusso @ggreif
bugfix: alternative to #4106 (#4107)
d778bb3 
* localize state using a functor

* Update src/mo_idl/mo_to_idl.ml

Co-authored-by: Gabor Greif <gabor@dfinity.org>

---------

Co-authored-by: Gabor Greif <gabor@dfinity.org>
@chenyan-dfinity
Merge branch 'master' into yan/fix-global
520c9fd
@chenyan-dfinity chenyan-dfinity added the automerge-squash When ready, merge (using squash) label Jul 6, 2023
ggreif
ggreif reviewed Jul 6, 2023
View reviewed changes
src/mo_idl/mo_to_idl.ml Outdated Show resolved Hide resolved
@chenyan-dfinity @ggreif
Update src/mo_idl/mo_to_idl.ml
64c5fa0 
Co-authored-by: Gabor Greif <gabor@dfinity.org>
@mergify mergify bot merged commit 51c16d1 into master Jul 6, 2023
7 of 8 checks passed
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Jul 6, 2023
@mergify mergify bot deleted the yan/fix-global branch July 6, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif left review comments

@crusso crusso crusso approved these changes

@rvanasa rvanasa rvanasa approved these changes

Assignees
No one assigned
Labels
build_artifacts Upload moc binary as workflow artifacts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate compiler crash
4 participants
@chenyan-dfinity @crusso @rvanasa @ggreif