Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTS Refactoring #4204

Merged
merged 4 commits into from
Sep 20, 2023
Merged

RTS Refactoring #4204

merged 4 commits into from
Sep 20, 2023

Conversation

luc-blaeser
Copy link
Contributor

@luc-blaeser luc-blaeser commented Sep 13, 2023 •
edited
Loading

  • Make memory_check feature flag compilable again.
  • Eliminate compiler warnings in RTS test.
  • Support region0 in RTS tests. (Btw: The region0 root has only been moved because it is not an array, not omitted. Previously, the declared region0 parameters were unused.)

@luc-blaeser
Refactoring: Make memory_check mode functioning again, support `reg…
aa4db17 
…ion0` in RTS unit tests, remove compiler warnings in RTS test
@luc-blaeser luc-blaeser self-assigned this Sep 13, 2023
@luc-blaeser luc-blaeser marked this pull request as ready for review September 13, 2023 11:54
@github-actions
Copy link

github-actions bot commented Sep 13, 2023 •
edited
Loading

Comparing from e47d953 to 367fff6:
In terms of gas, 1 tests regressed, 1 tests improved and the mean change is -0.2%.
In terms of size, 5 tests improved and the mean change is -0.0%.

crusso
crusso approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but didn't look that closely since mostly adjusting tests.
You seem to be merging the region0 root and continuation table which, to me, makes the code more obscure - what's the motive for this change. Does it make it less likey to forget the root?

Thanks for reducing cost of stable-region-migration test that often kills CI.

rts/motoko-rts-tests/src/gc/heap.rs Outdated Show resolved Hide resolved
@luc-blaeser @crusso
Update rts/motoko-rts-tests/src/gc/heap.rs
a00a4c0 
Co-authored-by: Claudio Russo <claudio@dfinity.org>
crusso
crusso approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"double-plus good"

@luc-blaeser
Copy link
Contributor Author

"double-plus good"

Thank you for the review and feedback.

@luc-blaeser luc-blaeser added the automerge-squash When ready, merge (using squash) label Sep 20, 2023
@mergify mergify bot merged commit 7081e3d into master Sep 20, 2023
9 checks passed
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Sep 20, 2023
@mergify mergify bot deleted the luc/rts-refactoring branch September 20, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crusso crusso crusso approved these changes

@ggreif ggreif Awaiting requested review from ggreif

@matthewhammer matthewhammer Awaiting requested review from matthewhammer

Assignees

@luc-blaeser luc-blaeser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luc-blaeser @crusso