experiment: only warn on unused identifiers if type-checking is (proper) error-free #4561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc-blaeser
approved these changes
Jun 6, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
…gs on Type Check Errors) (#4560) Fix for issue: #4508 * Correctly detect used and unused declaration in switch and try-catch clauses. Only warn on unused identifiers if type-checking is error-free (#4561) * Avoid potential spurious cascading warnings in the presence of type checker errors. Updated: * Expected warnings in Motoko test cases. * Refactoring of the Motoko base library to comply with the improved detection: dfinity/motoko-base#636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #4560
This should avoid false positives due to error recovery. Does however, remove many unused warnings from tests that contain real errors, preventing unused warnings from being reported.