-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Preparation: Merge Precise Object Tagging to Graph Copy EOP #4567
Merge Preparation: Merge Precise Object Tagging to Graph Copy EOP #4567
Conversation
…t.Array in compile.ml
…stream_write_text to accept blob or text
…_to_blob to produce TAG_BLOB_B
Co-authored-by: Luc Blaeser <112870813+luc-blaeser@users.noreply.github.com>
…-stable-heap64-merge-object-tagging
…-stable-heap64-merge-object-tagging
…-stable-heap64-merge-object-tagging
…-stable-heap64-merge-object-tagging
…-stable-heap64-merge-object-tagging
rts/motoko-rts/src/memory.rs
Outdated
debug_assert!( | ||
tag == TAG_ARRAY_I || tag == TAG_ARRAY_M || tag == TAG_ARRAY_T || tag == TAG_ARRAY_S | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug_assert!( | |
tag == TAG_ARRAY_I || tag == TAG_ARRAY_M || tag == TAG_ARRAY_T || tag == TAG_ARRAY_S | |
); | |
debug_assert!(is_base_array_tag(tag)); |
(Might need to import it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I addressed it in the lower PRs and merge the refactoring upwards.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. There might be a bit of unnecessary overhead passing those mostly redundant object_kinds around but perhaps we shouldn't sweat the small stuff.
…eap64-merge-object-tagging
…copy-on-stable-heap64-merge-object-tagging
Thank you very much for the review. Indeed, some |
(Still LGTM) |
Preparing merging #4544 in #4475 (level 3 of PR stack)