discord: Add new select components #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation doesn't seem to suggest this, so I agree. Are there any other components that still use |
|
No other components use |
diamondburned
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the new select components. It also renames
SelectComponenttoStringSelectComponentin-line with the documentation.TextInputComponent.Valuewas also changed fromoption.NullableStringtostringas I don't see a reason for it to be optional - when you submit from a modal, the values in the text input components are sent to the API and then received as aMESSAGE_COMPONENTinteraction event where the attached components have the same values submitted into the modal, so I can't see where it would need to be nullable?