Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using Xcode 15's gcc when compiling glog #48

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

stevenpetryk
Copy link

@stevenpetryk stevenpetryk commented Nov 28, 2023

Xcode 15's version of gcc seems to break the build of glog (a dependency of React Native). Since we run pod install inside of a Nix shell, though, I feel pretty safe falling back to the environment's gcc (rather than using Xcode's).

I can only assume that RN was doing this to try to make the compilation more hermetic, but we are already wrapping it in a hermetic environment.

@stevenpetryk stevenpetryk changed the base branch from master to 0.72.3-discord-1 November 28, 2023 22:24
@stevenpetryk stevenpetryk marked this pull request as ready for review November 28, 2023 22:32
@stevenpetryk stevenpetryk merged commit d8f198c into 0.72.3-discord-1 Nov 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant