Silence warnings display by python unit tests #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
portante
force-pushed
the
rm-pytest-warnings
branch
from
0400233
to
ff22deb
Compare
webbnh
requested changes
Jan 12, 2023
portante
force-pushed
the
rm-pytest-warnings
branch
2 times, most recently
from
55a0571
to
284f23a
Compare
dbutenhof
previously approved these changes
Jan 12, 2023
There were two categories of warnings being displayed, those related
to the xdist plugin, and those related to SQLAlchemy 2.0 migration.
The xdist plugin warnings are due to a bug in pytest-cov, see:
pytest-dev/pytest-cov#557
We just ignore them entirely for now, as that issue seems to be quiet.
The SQLAlchemy 2.0 migration warnings have 2 sub-categories. The
first being that `declarative_base` has moved modules, and that warning
is removed by using the proper import.
However, once that `declarative_base` warning is removed, one
encounters:
.../pbench/server/database/models/datasets.py:875:
RemovedIn20Warning: "Metadata" object is being merged into a
Session along the backref cascade path for relationship
"Dataset.metadatas"; in SQLAlchemy 2.0, this reverse cascade
will not take place. Set cascade_backrefs to False in either
the relationship() or backref() function for the 2.0 behavior;
or to set globally for the whole Session, set the future=True
flag (Background on SQLAlchemy 2.0 at:
https://sqlalche.me/e/b8d9)
meta = Metadata(**kwargs)
Since we are no going to migrate to SQLAlchemy 2.0 any time soon, it
seemed appropriate to just use the big hammer and turn the warnings
off entirely.
portante
force-pushed
the
rm-pytest-warnings
branch
from
284f23a
to
1b16727
Compare
dbutenhof
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two categories of warnings being displayed, those related to the xdist plugin, and those related to SQLAlchemy 2.0 migration.
The xdist plugin warnings are due to a bug in pytest-cov, see pytest-dev/pytest-cov#557. We just ignore them entirely for now, as that issue seems to be quiet.
The SQLAlchemy 2.0 migration warnings have 2 sub-categories. The first being that
declarative_basehas moved modules, and that warning is removed by using the proper import.However, once that
declarative_basewarning is removed, one encounters:Since we are no going to migrate to SQLAlchemy 2.0 any time soon, it seemed appropriate to just use the big hammer and turn the warnings off entirely.