Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to ansible roles (fwd port of #3478) #3479

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

ndokos
Copy link
Member

@ndokos ndokos commented Jul 4, 2023

  • repo.name -> repo.tag

  • assert that `pbench_repo_name' is defined (users have to define it in their inventory)

  • use `latest' when installing packages and stop ansible-lint from complaining about it

These fixes are incorporated into the pbench.agent collection, v1.0.11, available from Galaxy.

PBENCH-1129

@ndokos ndokos added bug Agent Ansible Ansible playbooks for pbench agent installation labels Jul 4, 2023
@ndokos ndokos added this to the v0.73 milestone Jul 4, 2023
@ndokos ndokos self-assigned this Jul 4, 2023
- repo.name -> repo.tag

- assert that `pbench_repo_name' is defined (users have to define it
  in their inventory)

- use `latest' when installing packages and stop ansible-lint from
  complaining about it

PBENCH-1129
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbutenhof
Copy link
Member

Rebasing will pick up Webb's legacy test fix. 😆

@webbnh
Copy link
Member

webbnh commented Jul 5, 2023

Rebasing will pick up Webb's legacy test fix. 😆

I'm not sure that that fix covers this problem. 😢

@ndokos
Copy link
Member Author

ndokos commented Jul 5, 2023

So what do they keep in Area-52?

@webbnh
Copy link
Member

webbnh commented Jul 5, 2023

"pbench-tool-meister-stop" failed to execute successfully (exit code: 124)

I believe that that is a timeout. I'm inclined to say that that is nondeterministic behavior resulting from environmental effects.

@ndokos ndokos merged commit b6d63ed into distributed-system-analysis:main Jul 6, 2023
3 checks passed
@ndokos ndokos deleted the ansible-fixes-main branch July 6, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Ansible Ansible playbooks for pbench agent installation bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants