Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some problems with archive-only behavior #3497

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

dbutenhof
Copy link
Member

PBENCH-1215

Webb pointed out a broken functional test in #3496. Once it was testing what I had wanted it to test, I realized that it wasn't quite working. This contains some server and functional test changes to make archive-only dataset queries work correctly and to be sure that's adequately tested in the functional test cases.

@dbutenhof dbutenhof added Server API Of and relating to application programming interfaces to services and functions Functional Testing labels Jul 20, 2023
@dbutenhof dbutenhof requested review from ndokos and webbnh July 20, 2023 21:59
@dbutenhof dbutenhof self-assigned this Jul 20, 2023
webbnh
webbnh previously approved these changes Jul 21, 2023
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks OK but I have a couple of suggestions which I hope you'll consider including.

ndokos
ndokos previously approved these changes Jul 21, 2023
PBENCH-1215

Webb pointed out a broken functional test in distributed-system-analysis#3496. Once it was testing what I
had wanted it to test, I realized that it wasn't quite working. This contains
some server and functional test changes to make archive-only dataset queries
work correctly and to be sure that's adequately tested in the functional test
cases.
Copy link
Member

@webbnh webbnh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbutenhof dbutenhof merged commit 971ed19 into distributed-system-analysis:main Jul 26, 2023
3 checks passed
@dbutenhof dbutenhof deleted the funbug branch July 26, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Of and relating to application programming interfaces to services and functions Functional Testing Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants