Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: remove overlay xref to pkgs #61

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

blaggacao
Copy link
Contributor

since packages are exposed through output.packages by their own,
a second export through overlays.pkgs would be smudging the public api
of this repository.

since packages are exposed through output.packages by their own,
a second export through overlays.pkgs would be smudging the public api
of this repository.
@blaggacao blaggacao force-pushed the da-separate-pkgs-from-overlays branch from 45869c2 to 94f334e Compare December 30, 2020 16:54
@blaggacao
Copy link
Contributor Author

blaggacao commented Dec 30, 2020

I see that ./pkgs are implemented as overlays, as well. Consequentially, I see an opportunity to re-export local packages simply by namespacing them, as in this example — without any interference into overlays (so they are "special" type of overlays that only goes into overlay)

@nrdxp nrdxp self-requested a review December 30, 2020 20:32
Copy link
Collaborator

@nrdxp nrdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your right, there is no reason to have pkgs in both overlays.pkgs and as the overlay.

@nrdxp nrdxp merged commit 09f0bbd into divnix:template Dec 30, 2020
nrdxp added a commit that referenced this pull request Dec 31, 2020
Packages from `pkgs/default.nix` are meant to be exposed to all nixos
configurations. However, #61 removed a redundancy in the output api
which was  relied up to do so.
nrdxp added a commit that referenced this pull request Dec 31, 2020
Packages from `pkgs/default.nix` are meant to be exposed to all nixos
configurations. However, #61 removed a redundancy in the output api
which was  relied up to do so.
blaggacao pushed a commit to blaggacao/devos that referenced this pull request Jul 6, 2021
blaggacao pushed a commit to blaggacao/devos that referenced this pull request Jul 6, 2021
Packages from `pkgs/default.nix` are meant to be exposed to all nixos
configurations. However, divnix#61 removed a redundancy in the output api
which was  relied up to do so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants