Skip to content
This repository has been archived by the owner on Jan 26, 2024. It is now read-only.

Adding desktop file entry for QOL #484

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Adding desktop file entry for QOL #484

merged 1 commit into from
Sep 23, 2023

Conversation

weiseguy1
Copy link

Updated the original makeDesktop patch

@pm4rcin
Copy link

pm4rcin commented Sep 21, 2023

@sevz17 I'm wondering if it couldn't be merged since it doesn't increase SLOC in dwl.c nor any header files and is just a few lines in Makefile. Also it just makes things easier if someone uses login manager since it's automatically discoverable. It doesn't alter the behaviour of dwl but it's just QOL improvement for people that need it.

@sevz17
Copy link
Collaborator

sevz17 commented Sep 22, 2023

@sevz17 I'm wondering if it couldn't be merged since it doesn't increase SLOC in dwl.c nor any header files and is just a few lines in Makefile. Also it just makes things easier if someone uses login manager since it's automatically discoverable. It doesn't alter the behaviour of dwl but it's just QOL improvement for people that need it.

Well, dwm doesn't include it so neither do we, but meh, let's do it.

Also do note that just like sway we don't support login managers (I know, it's not mentioned anywhere, I want add it and more documentation but I haven't had time)

@weiseguy1
Copy link
Author

Not gonna lie, this is pretty cool considering this is my first pull request to a major project!

Makefile Outdated Show resolved Hide resolved
dwl.desktop Outdated Show resolved Hide resolved
dwl.desktop Outdated Show resolved Hide resolved
dwl.desktop Outdated Show resolved Hide resolved
@pm4rcin
Copy link

pm4rcin commented Sep 22, 2023

One last thing to do. Squash the commits into one and that's it from my perspective.

@weiseguy1
Copy link
Author

done

@pm4rcin
Copy link

pm4rcin commented Sep 22, 2023

Give that commit sensible name like Add desktop entry file or something similar. Also change the PR name since it's meaning has changed.

@weiseguy1 weiseguy1 changed the title Updated makedesktop patch Adding desktop file entry for QOL Sep 22, 2023
@sevz17
Copy link
Collaborator

sevz17 commented Sep 22, 2023

Please s/Added/Add/ in the commit message

@sevz17 sevz17 merged commit 773bd04 into djpohly:main Sep 23, 2023
@sevz17
Copy link
Collaborator

sevz17 commented Sep 23, 2023

Thank you!

@weiseguy1 weiseguy1 deleted the makedesktop branch September 23, 2023 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants